Skip to content

馃悰 fix(windows): ignore UNC overrides missing a share - #647

Open
RedCat888 wants to merge 3 commits into
tox-dev:mainfrom
RedCat888:fix/incomplete-unc-overrides
Open

RedCat888 wants to merge 3 commits into
tox-dev:mainfrom
RedCat888:fix/incomplete-unc-overrides

Conversation

@RedCat888

@RedCat888 RedCat888 commented Oct 27, 2026 •

Copy link
Copy Markdown

Setting a Windows folder override such as WIN_PD_OVERRIDE_LOCAL_APPDATA to an incomplete UNC path like \\server made platformdirs treat the application name as the share, so user_data_dir came back as \\server\app. 馃獰 Overrides now need both a server and a share name, in the plain form and in the extended \\?\UNC\ form, as the UNC path format requires. An incomplete value falls back to the normal folder, like any other invalid override.

The override validation stays the single gate between the environment and the folder lookup. Complete UNC paths, drive-rooted paths and extended paths keep working, and the explanation docs list the rejected shapes.

@RedCat888

Copy link
Copy Markdown
Author

CI status for current head 37000ba7056a70a946a4599ed97a92faf273dfd1: Read the Docs and pre-commit.ci both passed. The four GitHub Actions runs (Release, Changelog, CodeQL, and check) each report action_required and zero jobs. They are awaiting fork-workflow approval; no failing job has executed.

A maintainer with write access needs to use Approve workflows to run on this PR. This account has pull access only. Representative run: check.

Local validation is recorded in the PR description: full suites on native Windows/Python 3.13 and 3.14 (2,048 passed, 350 skipped each), Windows tests on Python 3.11 (208 passed, 20 skipped), 100% changed-line coverage, type checks, formatting, and the documentation build.

An override of \\?\UNC\server still passed: the check read ? as the
server and UNC\server as the share, so the app name became the share.
Skip the \\?\UNC\ prefix before splitting server and share, and
normalize slashes once up front. The changelog and docs now cover a
missing server as well.
@gaborbernat gaborbernat changed the title fix: ignore incomplete UNC folder overrides on Windows 馃悰 fix(windows): ignore UNC overrides missing a share Oct 28, 2026
@gaborbernat gaborbernat added the bug Something isn't working label Oct 28, 2026
@RedCat888

Copy link
Copy Markdown
Author

Validated the extended-UNC correction in b7d6c926e85e36764ea21dd1c93fdedd4910c1b6 on native Windows:

  • Full suite, Python 3.14.2: 2,051 passed, 350 skipped.
  • Windows suite, Python 3.11.14: 211 passed, 20 skipped.
  • ty check src tests: passed.

The cancelled attempt-2 jobs have concurrency annotations saying a higher-priority request was waiting for the same PR. Maintainer-triggered attempt-3 replacements are already running; the release build and changelog replacements have succeeded. No duplicate rerun was requested.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants