Repository navigation
Conversation
Muguett-DBY
approved these changes
Oct 25, 2026
Muguett-DBY
left a comment
There was a problem hiding this comment.
Tested 411d04d on CPython 3.12: Linux and macOS each had 2,268 passed / 125 skipped; Windows had 2,043 passed / 350 skipped.
Both added regressions fail with the original testing.py restored. I also checked deferred context entry, nested relative roots with exception restoration, parent-relative Path inputs, directory symlinks, and Windows drive-relative roots. These pass with the fix, including directory creation after changing cwd. The absolute-root check confirms that existing .. components are retained, and the symlink check confirms that the alias spelling is preserved.
Test source and logs. No issues found in this scope. Reviewed with Codex assistance.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isolated_dirs("sandbox")retains a relative root. If the test changes its working directory inside the context, every redirected path follows the new working directory, andensure_exists=Truecreates directories outside the original isolation root. Passing"."has the same problem.Make the root absolute once when entering the context. Directory lookups, directory creation and the yielded root then keep referring to the original location across working-directory changes. Absolute roots keep their existing behavior.
Add two regression cases covering
"."and a named relative root. Each checks all directory accessors and iterators, the yielded root, and actual directory creation after changing directories. Both fail on the original implementation and pass with the fix. Update the helper documentation, how-to guide and changelog.Validation:
Tox tooling uses local overrides selecting Python 3.14 instead of the unavailable configured Python 3.15. The initial aggregate run flagged formatter changes; its
fixenvironment passed on rerun. Python 3.12, Windows 3.13, 3.15, PyPy and free-threaded interpreters were unavailable; native macOS was not tested. No repository test, workflow or tooling configuration is changed.Prepared and tested with Codex assistance.