Repository navigation
fix: honor overridden path iterators during file lookup - #640
Open
KennyMcSimpson wants to merge 1 commit into
Open
KennyMcSimpson wants to merge 1 commit into
KennyMcSimpson wants to merge 1 commit into
Conversation
|
Hell |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_config_file()and its equivalents promise to search initer_*_paths()order, but they invoke the methods onPlatformDirsABCdirectly. Subclasses that customize those public iterators lose their search paths during file lookup, so an existing configuration returned byiter_config_paths()is reported missing.Resolve each iterator from the concrete class while retaining the copy with
ensure_exists=False. Add regressions for all six directory kinds, both lookup forms, ordering and read-only behavior; document the subclass behavior and include a changelog fragment.Validation on Windows:
The complete aggregate tox run was followed by a passing fix rerun after normalizing local YAML line endings. No workflow changes are included.
Prepared with AI assistance.