Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A synchronous nested acquisition of an already-held FileLock or SoftFileLock still calls ensure_directory_exists(). If the parent directory was renamed while the lock was held, this recreates the original directory. If a regular file has since taken that name, nested acquisition raises FileExistsError instead. In that failure case the recursion count also remains incremented, so leaving the outer context does not release the hold.
Only create the parent directory when the lock is not already held. Reentrant acquisition joins the existing descriptor and keeps balanced recursion counts. Initial acquisition still creates the directory once before polling, preserving the existing behavior when a directory disappears while a contender waits.
Add four Linux/POSIX regression cases: native and soft locks, with the old parent name either absent or replaced by a file. All four fail on the base revision and pass with the fix.
Validation:
Prepared and tested with Codex assistance. The full repository test suite and CI platform matrix were not run locally.