Repository navigation
test: avoid localized messages in closed-descriptor checks - #875
Open
KennyMcSimpson wants to merge 1 commit into
Open
KennyMcSimpson wants to merge 1 commit into
KennyMcSimpson wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Chinese-language Windows,
test_strict_soft_sentinel_inspection_failure_closes_descriptorfails because the OS returns[WinError 6] 句柄无效。, which does not match its hard-coded English messages. The file descriptor is correctly closed.Check
OSError.errno == EBADFdirectly withpytest.raises(check=...), replacing the message match and subsequent errno assertion. This retains the closed-descriptor check regardless of the OS language and follows the predicate style used elsewhere in the suite.Validation on Windows / Python 3.13:
git diff --checkpass.Developed with OpenAI Codex assistance.