Repository navigation
feat(bath): name KTON's liquid staking actions kton, not liquidTF - #991
Open
awesome-doge wants to merge 2 commits into
Open
awesome-doge wants to merge 2 commits into
awesome-doge wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #990 (it uses the KTON constants added there).
KTON runs its own liquid staking pool on a newer version of the Tonstakers contract. Its deposits, withdraw requests and withdrawals are classified by op code, so they come out as
liquidTF, and the apps show them as Tonstakers: iOSMultichainHistoryStakingProvider, AndroidHistoryStakingProviderand webpoolBranding.tsall mapliquidTFto Tonstakers.This adds
ktontoPoolImplementationType(ashipoandffvaultwere added) and sets it when the pool is KTON's or the burned jetton is KTON. Everything else staysliquidTF. The clients fall back to a generic stake item for a value they don't know, as they do forhipotoday. I could not check whether the wallet history backend passes this field through.Tested: three KTON traces from mainnet (deposit, withdraw request, instant withdraw) with goldens, a unit test that the Tonstakers pool keeps
liquidTF,go generatewith only the enum in the diff,go vetandgo build ./.... The existing liquid staking cases fail locally withnot found txon master too (the public liteservers no longer have those blocks), so I could not rerun them.