Repository navigation
Retain valid model results across collection updates - #1096
Draft
dlukeomalley wants to merge 2 commits into
Draft
dlukeomalley wants to merge 2 commits into
dlukeomalley wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection updates currently erase the entire model-result cache, even when nothing changed. Both CLI indexing paths and the public SDK update do this. Repeated searches therefore lose reusable query expansions and rerank scores.
Keep those entries through indexing and qualify the rerank cache at its owner:
This retains model results, not retrieved documents or final rankings. Index scans, fresh retrieval and fusion still execute. Replacing model weights under an unchanged URI or changing future prompt/scoring implementations still requires a cache version change or explicit cleanup. A successful local model literally named fallback conservatively receives no persistent reuse because that name collides with the existing degraded-result marker.
Regression witnesses failed before correction for SDK/CLI invalidation, fallback persistence, legacy intent and context-size changes. Tests use actual stores and LlamaCpp instances with public model-method spies; the context boundary runs in two processes. No model-quality or latency improvement is inferred from these deterministic controls.
Validation at 4a6d1b0:
Model-dependent integration cases remain skipped in CI mode. The CLI update cache control uses an empty collection registry; populated update/reuse is covered through the SDK, and collection-add indexes real fixtures. These checks do not establish live inference correctness or broad retrieval quality.