Repository navigation
chore: roll up security migration changes - #319
Merged
senamakel merged 15 commits intoOct 30, 2026
Merged
Conversation
The EngineResolver trait now exposes an async resolve method, and all call sites await it. This lets resolvers perform asynchronous work such as I/O when locating the configured engine and identity instead of blocking the caller. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Add a DeferredResolver test double whose resolve future stays pending until released, and a test asserting that pre_turn does not complete while engine resolution is still in flight. This pins down the ordering guarantee that citations are not recorded before the engine memory is available. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
…lock The StaticResolver implementation of EngineResolver was missing the async_trait attribute, so it now matches the trait's async signature. The DeferredResolver resolve method also drops its mutex guard before awaiting the release, avoiding holding the lock across an await point. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Track resolver invocations with an atomic counter so the pre-turn test can verify the async engine resolution is awaited exactly once before proceeding. The fixture now clones the resolver handle to keep it accessible after the turn completes. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
The test now clones the resolver before passing it to TurnHooks so the original binding stays available for later assertions. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
The fixture builder cloned the resolver before moving it into the struct, which was unnecessary since the value is not used afterwards. Removing the clone keeps the test setup free of a needless allocation. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Bumps tokio from 1.53.1 to 1.53.3 and downgrades the windows-sys dependency pulled in by several crates from 0.61.2 to 0.52.0. The lockfile was regenerated to reflect the resolved dependency graph. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Make TinyMemory engine resolution async
…o sec-656-secret-cipher
Sync active TinyMemory pin with async resolver
The reachability probe is now an async method so executors can await a real backend check instead of blocking, and the drain path awaits it before running anything. A test with a deferred reachability future covers the new behaviour. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
The engines accessor on the LayoutHost trait is now async, and its call sites in the migration job and scan service await it. This lets hosts resolve engines through asynchronous work instead of blocking, and the test hosts were updated to match the new signature. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
The LayoutHost::legacy_claim method is now async, and its callers in the migration job and scan service await it. This lets host implementations perform asynchronous work when acquiring the legacy claim instead of blocking the caller. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
refactor(deletion): make reachability async
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Await reachability before deletion crates/tinymemory-tools/src/deletion/mod.rs, crates/tinymemory-tools/src/deletion/mod_tests.rs |
DeletionExecutor::is_reachable is asynchronous, and DeletionQueue::drain awaits it before running queued deletions. The test executor and tests cover a deferred reachability check. |
Layout Migration
| Layer / File(s) | Summary |
|---|---|
Await layout host lookups crates/tinymemory-tools/src/layout_migration/job.rs, crates/tinymemory-tools/src/layout_migration/service.rs, crates/tinymemory-tools/src/layout_migration/service_tests.rs, crates/tinymemory-tools/src/layout_migration/test_host.rs |
LayoutHost::engines and LayoutHost::legacy_claim are asynchronous. Migration jobs, scans, and host implementations await or implement these methods. |
Turn Lifecycle Resolution
| Layer / File(s) | Summary |
|---|---|
Await engine resolution in lifecycle hooks crates/tinymemory-tools/src/lifecycle/turn.rs, crates/tinymemory-tools/src/lifecycle/turn_runtime_tests.rs |
EngineResolver::resolve is asynchronous. Pre-turn, post-turn, and compaction hooks await resolution. Tests cover deferred pre-turn resolution. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Refactor
Suggested reviewers: m3ga-mind
Merge Risk: 
4ee5d
-
No blocking issue is established. Verify downstream host compatibility when advancing the gitlink.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title identifies the pull request as a roll-up of migration-related changes. It does not name the main asynchronous API updates, but it remains related to the changeset. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 10 functions across 8 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
⚔️ Resolve merge conflicts: 💡
-
- Resolve merge conflict in branch
epic/8369-security-migration
- Resolve merge conflict in branch
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the queue at dawn,
Then waits until the pause is gone.
The engines answer, calm and clear,
The turn resumes when they appear.
Soft paws mark each awaited hop,
And queued deletions wait, then pop.
Comment @coderabbitai help to get the list of available commands.
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): chore: roll up security migration changes. Tiny Sweeper completed its review; deterministic results follow. Review snapshot
Completeness: Complete Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
tinysweeper
Bot
added
the
priority: p2
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Co-authored-by: Medulla <medulla@tinyhumans.ai>
tinysweeper
Bot
added
priority: p3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream roll-up required before OpenHuman can advance its gitlink. Carries commit 4ee5d0c referenced by tinyhumansai/openhuman#8487. Validation: source commit verified; tests were not run for this roll-up.
Summary by CodeRabbit