Repository navigation
fix: avoid deprecated Atomic::fetch_update on rustc 1.99 - #316
Conversation
The permit acquisition path now uses an explicit compare_exchange_weak loop instead of fetch_update, since fetch_update is deprecated in favour of try_update on newer toolchains but try_update is not stable on this crate's MSRV. A test covers concurrent acquires to confirm the pool never grants more permits than its size. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Annotate the two `fetch_update` call sites with `#[allow(deprecated)]` and bind the result to a local, since the replacement `try_update` is not stable on this crate's MSRV. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): fix: avoid deprecated Atomic::fetch_update on rustc 1.99. This pull request, titled "fix: avoid deprecated Atomic::fetch_update on rustc 1.99," replaces uses of `Atomic::fetch_update` — deprecated on Rust 1.99 in favor of `try_update`, which is not stable on the crate's MSRV 1.96 — with behavior-equivalent alternatives across the prefetch worker pool and two test helpers, and adds a concurrency test for the worker pool. No trusted push-delta comparison is available, so no push-delta analysis is reported. Review snapshot
Completeness: Complete What changed`WorkerPool::try_acquire` in crates/tinymemory-tools/src/prefetch/mod.rs now uses a `compare_exchange_weak` loop instead of `fetch_update`, loading `free` with `Acquire`, returning `None` when `checked_sub(1)` fails (pool exhausted), and retrying with the observed value on contention; a grant returns a `Permit` whose `Drop` releases the unit. Two test helpers — the `take_one` decrement helper in crates/tinymemory-integrations/src/cortex/testing/mod.rs and the flaky `ListStore` save counter in crates/tinymemory-tools/src/deletion/mod_tests.rs — keep `fetch_update` but gain `#[allow(deprecated)]` with an MSRV comment. A new test, `concurrent_acquires_never_exceed_the_pool_size`, spawns 16 scoped threads against a pool of 3 and asserts exactly 3 permits are granted and availability returns to 3 after release. Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Retain fetch_update calls crates/tinymemory-integrations/src/cortex/testing/mod.rs, crates/tinymemory-tools/src/deletion/mod_tests.rs |
Both existing fetch_update calls receive local deprecation allowances. The Flaky::save helper stores the update result before checking whether to return its existing error. |
Use compare-exchange for worker acquisition crates/tinymemory-tools/src/prefetch/mod.rs, crates/tinymemory-tools/src/prefetch/mod_tests.rs |
WorkerPool::try_acquire retries a weak compare-exchange after contention and returns no permit when the count is zero. A concurrent test checks that a pool of size three grants exactly three permits and restores the count when they are dropped. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: m3ga-mind
Merge Risk: 
edb2c
-
Worker permit limits and recovery remain intact; the change is ready to merge after normal checks.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title "fix: avoid deprecated Atomic::fetch_update on rustc 1.99" matches the main change. The PR replaces the fetch_update call in WorkerPool::try_acquire with a compare_exchange loop, adds a conc… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title "fix: avoid deprecated Atomic::fetch_update on rustc 1.99" matches the main change. The PR replaces the fetch_update call in WorkerPool::try_acquire with a compare_exchange loop, adds a concurrency test, and silences the deprecation warning at two test-helper call sites. The title names the deprecated API and the compiler version that triggers the warning. It does not mention the new concurrency test, but that test is secondary to the fix.
-
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit counts the workers three,
Then waits for compare-exchange to agree.
Sixteen paws reach for a turn,
Three permits go out, then return.
The counter rests, as calm as can be.
Comment @coderabbitai help to get the list of available commands.
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
tinysweeper
Bot
added
the
priority: p3
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Rust 1.99 deprecates
Atomic::fetch_update(renamedtry_update, not stable on MSRV 1.96).WorkerPool::try_acquire: compare_exchange loop with identical semantics; new testconcurrent_acquires_never_exceed_the_pool_size.#[allow(deprecated)]with MSRV comment.Verified: clippy
-D warningson 1.96.1 and 1.99.1, fmt, doc, nextest 1781/1781.Summary by CodeRabbit