Skip to content

test(failure): pin that provider detail scrubs a key the provider echoes #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
M3gA-Mind merged 1 commit into from
Oct 23, 2026
Merged

test(failure): pin that provider detail scrubs a key the provider echoes #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions crates/tinyinference-llm/src/failure_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,21 @@ fn extract_provider_error_detail_pulls_openai_message() {
assert!(detail.contains("gpt-5.5"));
}

#[test]
fn extract_provider_error_detail_scrubs_a_key_the_provider_echoes() {
// The detail is quoted to the user, and providers echo a rejected key in
// it. Synthetic keys, built at runtime so no key-shaped literal is committed.
let body = "AbCdEf0123456789".repeat(2);
for key in [format!("sk-proj-{body}"), format!("sk-ant-api03-{body}")] {
let raw = format!(
r#"someprovider API error (422 Unprocessable Entity): {{"error":{{"message":"bad parameter for key {key}"}}}}"#
);
let detail = extract_provider_error_detail(&raw).expect("expected JSON message");
assert!(detail.contains("bad parameter"), "got: {detail}");
assert!(!detail.contains(&body), "key leaked: {detail}");
}
}

#[test]
fn extract_provider_error_detail_returns_none_for_transport_errors() {
// Plain transport failure — no provider JSON body to quote. Surfacing
Expand Down
Loading