Repository navigation
Bump OpenHuman to latest main and adapt to spawn_subagent - #133
Conversation
Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Bump the vendored openhuman submodule and refresh Cargo.lock to match. The lockfile picks up new jaq crates, drops the tinyagents-graph and tinytools-std entries, and moves tinyagents-definition and tinyagents-harness to 3.0.0. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the openhuman and openhuman-embed git revisions to 5f8b7c235f18b46f90fabbf1e7f1b8d9a957cee6 so the workspace tracks the newer upstream commit. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the pinned revisions for the tinytools and tinytools-agent git dependencies to the same newer commit. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the tinymemory-api and tinymemory-tools git revisions to 8b919fd6d0b99e06269cab84de0c715772d0c49f so the vendored crates match the commit OpenHuman's tree pins. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the pinned tinyflows revision so the vendored scheduler matches the commit OpenHuman's tree expects, keeping the re-exported `Schedule` type in sync with `openhuman::cron`. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Turn on the channels feature for the openhuman dependency so the channel-related APIs are available to the workspace. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
OpenHuman's agent bus calls channels::run_channel_turn unconditionally, so its tree does not build without the channels feature enabled. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Adds a temporary eprintln in the delegation test script to dump the request tools, message count, last role, and episode presence, making it easier to inspect what the model receives during delegation runs. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Adjust the debug logging to print the last message content instead of the tool list, and switch the delegated call from delegate_helper to spawn_subagent with an agent_id so the test matches the current delegation API. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Subagent delegation is now invoked through the `spawn_subagent` tool with an `agent_id` argument rather than per-profile `delegate_<profile>` tool names, so the permission check treated declared subagents as unknown effects and denied them. The check now matches `spawn_subagent` and reads the target from `agent_id`, and the tests and README were updated to the new call shape. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
The delegation test now counts every request without an episode as the native child's and waits for its second request before asserting, since spawn_subagent returns immediately and the child's follow-up only arrives after the write call is executed or denied. This removes the race that let the test pass before the child had actually run. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): Bump OpenHuman to latest main and adapt to spawn_subagent. Tiny Sweeper completed its review; deterministic results follow. Unreviewed paths
Review snapshot
Completeness: Complete What changedOpenHuman bump: `vendor/openhuman` moves to 5f8b7c2 and the `openhuman`, `openhuman-embed`, `tinytools`, `tinytools-agent`, `tinymemory-api`, `tinymemory-tools` and `tinyflows-schedule` git revs are re-pinned to what that tree vendors, with `openhuman` gaining the `channels` feature so it builds without default features. The permission engine (`impl Permissions` in `crates/tinyhivemind-openhuman/src/deploy/permission.rs`) now recognizes `spawn_subagent` with a `agent_id` matching a declared child as internal ReadOnly, replacing the `delegate_<id>` name check. Tests are updated to the new tool shape, the delegation test now waits up to 60s for the child's second request, the README line describes declared subagents spawned via `spawn_subagent`, and the `wiki` submodule is bumped. The seat-profile API consequence is that profiles declaring `subagents` expose `spawn_subagent` instead of `delegate_<profile>`, with no config-format change. Features
Tests
FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
vendor/openhumansubmodule to current OpenHumanmain(5f8b7c2) and re-pinopenhuman,openhuman-embed,tinytools*,tinymemory-*andtinyflows-scheduleto the revs that tree vendors (assert-openhuman-pin.shpasses).channelsfeature on theopenhumandependency: its agent bus callschannels::run_channel_turnunconditionally, so the tree no longer builds withdefault-features = falsealone. This is an upstream OpenHuman gating bug worth fixing there; the feature can be dropped once it is.delegate_<id>tools with one asynchronousspawn_subagenttool (child inagent_id). The permission engine now treatsspawn_subagentas an internal read-only call only whenagent_idnames a declared subagent; unknown ids still fall through to normal classification and are denied.spawn_subagentreturns before the child runs. Previously the assertion raced the child.API / behaviour changes
Seat profiles that declare
subagentsexposespawn_subagentinstead ofdelegate_<profile>(a consequence of the OpenHuman bump). No change to the config format.Validation
cargo fmt --all -- --check: okcargo clippy --all-targets --all-features -- -D warnings: okcargo build --all-targets --all-features: okcargo test --all-features: ok (openhuman lib 132/132, run three times after the race fix)RUSTDOCFLAGS="-D warnings" cargo doc --no-deps --all-features: okassert-openhuman-pin.sh,assert-pure.sh: okRelated issue: none.
Summary by CodeRabbit
New Features
spawn_subagent; these calls are treated as read-only. Attempts to start an agent that is not configured remain denied.Documentation