Repository navigation
ci(release): bump the workspace tinyflows requirement with the crate version - #178
Conversation
…version
The release step rewrote only crates/tinyflows/Cargo.toml. The root
workspace dependency every sibling crate inherits pins
tinyflows = { version = "0.8.0", path = ... }, so a minor bump to 0.9.0
no longer matched it and `cargo update --precise` failed to resolve.
Rewrite that requirement in the same step, assert it took, and include
the root manifest in the release commit.
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): ci(release): bump the workspace tinyflows requirement with the crate version. The release workflow now bumps the root workspace `tinyflows` dependency requirement along with the crate version, asserts the rewrite landed, and stages the root manifest in the release commit. No findings are recorded in any lane. Review snapshot
Completeness: Complete What changedIn `.github/workflows/release.yml`, the "Update crate version" step gains a `perl` substitution rewriting the root `[workspace.dependencies]` `tinyflows = { version = ..., path = "crates/tinyflows" }` requirement to `${NEXT_VERSION}` alongside the existing crate-manifest bump, plus a `grep -qx` assertion on the exact rewritten line. The subsequent commit step's `git add` now includes the root `Cargo.toml` so the manifest change is part of the release commit. No permissions or action pins are widened. Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
Comment |
Summary
The
release.ymldispatch for v0.9.0 (bump=minor, run 39998476560) failed at "Update crate version" before anything was committed, tagged or published:The step rewrites only
crates/tinyflows/Cargo.toml. The root workspace dependency thattinyflows-catalog,-copilot,-driversand-moduleinherit also pins a version:tinyflows = { version = "0.8.0", path = "crates/tinyflows" }(Cargo.toml:33). A patch bump still satisfies^0.8.0, which is why every 0.8.x release worked. A minor or major bump does not.The fix is in the release step, which every future bump goes through. It now:
grep -qxon the exact line, so a reformatted manifest fails loudly instead of silently skipping;Cargo.tomlto the release commit.Related issue
None.
API or behavior changes
None to the crate. Release commits now also touch the root
Cargo.toml.Validation
perlsubstitution withNEXT_VERSION=0.9.0on a copy of main's rootCargo.toml. Line 33 becomestinyflows = { version = "0.9.0", path = "crates/tinyflows" }, and thegrep -qxassertion matches it.release.ymldispatch after this merges.Tests
None. This is a CI workflow change.
Documentation
Not needed.
Checklist
#[allow(...)],#[ignore], or relaxed lints.envcontents in the diff or the description