Repository navigation
fix(config): stop re-exporting TinyAgents' ToolRendering from the config API (fixes red main) - #8481
Conversation
…fig API The agent-runtime boundary forbids re-exporting upstream types from core. Import ToolRendering privately in the context schema and name the harness path where core uses it.
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): fix(config): stop re-exporting TinyAgents' ToolRendering from the config API (fixes red main). Tiny Sweeper completed its review; deterministic results follow. Unreviewed paths
Review snapshot
Completeness: Complete What changedThe change is a visibility/import-surface refactor with no behavior change. In `config/schema/context.rs`, `ToolRendering` moves from a `pub use` to a private `use`, so `ContextSettings.summarizer_tool_rendering` and `SummarizerSettings.tool_rendering` still carry the upstream type while callers must name it from `tinyagents_harness`. `ToolRendering` is removed from the re-export lists in `config/schema/mod.rs` and `config/mod.rs`, and in `config/mod.rs` `SummarizerSettings` gains its own `pub use schema::SummarizerSettings;` line, reordering the re-export block for rustfmt stability. The two internal users now reference the harness path directly: the env overlay in `config/schema/load/env_overlay/context.rs` for the `full`/`markers` parsing of `OPENHUMAN_CONTEXT_SUMMARIZER_TOOL_RENDERING`, and the context-wiring test in `agent/tinyagents/context_wiring_tests.rs`. The same enum and variants are used throughout, so behavior is unchanged. Features
Tests
FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Type imports, exports, and configuration mapping crates/openhuman-core/src/config/mod.rs, crates/openhuman-core/src/config/schema/context.rs, crates/openhuman-core/src/config/schema/mod.rs, crates/openhuman-core/src/config/schema/load/env_overlay/context.rs, crates/openhuman-core/src/agent/tinyagents/context_wiring_tests.rs |
The configuration modules stop publicly re-exporting ToolRendering. Environment values and the markers-compaction test use the TinyAgents type. The accepted environment values and test assertions remain unchanged. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Possibly related issues
- Audit: move misplaced core code to its owner, remove shims, re-pointers and re-imports #7332: The changes remove a vendor type re-export and use the owning crate’s type directly.
- Epic: shrink openhuman-core outside the domain epics — file-by-file audit of 198.6k lines; move generic code to tiny* repos and openhuman-tinyhumans #7390: The changes remove a type from the core configuration API while retaining its use in configuration loading.
Suggested labels: rust-core, agent
Suggested reviewers: senamakel
Merge Risk: 
d9055
-
No actionable merge-blocking issue is identified; the change is ready for normal checks.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title names the main change: the config API no longer re-exports TinyAgents' ToolRendering type. The raw summary confirms this. The removal from config/mod.rs, config/schema/mod.rs, and config/sch… Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the main change: the config API no longer re-exports TinyAgents' ToolRendering type. The raw summary confirms this. The removal from config/mod.rs, config/schema/mod.rs, and config/schema/context.rs matches the title, and the title's reference to fixing red main matches the PR objectives, which cite the static:agent-runtime-boundary violation from
#8477. The title is specific and does not include a file list. It is 93 characters, which is longer than the usual short title, but it still reads clearly.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 4 files.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the type,
The core exports less today.
Env values still map,
The test keeps markers in view,
And hops along its way.
Comment @coderabbitai help to get the list of available commands.
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
tinysweeper
Bot
added
the
priority: p3
coderabbitai
Bot
added
agent
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
static:agent-runtime-boundaryfailed with "Unbaselined violations (1): openhuman-upstream-reexport: crates/openhuman-core/src/config/schema/context.rs:14:pub use tinyagents_harness::summarization::ToolRendering;". This came in with c07f411 (Compact idle threads, honour summarizer_model, add a memory block and per-turn recall #8477).config/schema/context.rsimportsToolRenderingprivately.ContextSettings.summarizer_tool_renderingandSummarizerSettings.tool_renderingkeep the upstream type, which callers name fromtinyagents_harnessdirectly.ToolRenderingis dropped from theconfig::schemaandconfigre-export lists.tinyagents_harness::summarization::ToolRendering, as the env-overlay tests already did.openhuman-corenamedopenhuman_core::config::ToolRendering.Proof (cuttlefish)
pnpm agent:runtime-boundaryexits 1 with theToolRenderingviolation (CF-BASE-3e0c980 static log).pnpm agent:runtime-boundaryexits 0: "Agent-runtime boundary holds (140 temporary exact violations baselined)". 0 baseline or boundary files changed.cargo check --locked --workspace --all-targets --features "<product>,bin-tools": exit 0.-p openhuman --lib --tests -D warnings: exit 0.config::schema::load | agent::tinyagents::context_wiring: 246/246 passed.cargo fmt --all --checkflagged theuseorder inconfig/mod.rs; fixed in d90552e.cargo fmt --all --checkexits 0,pnpm agent:runtime-boundaryexits 0, andcargo check --locked --workspace --all-targetsexits 0.Submission Checklist
Related