Repository navigation
fix(ui): pause mascot animation while hidden or reduced-motion is requested - #8435
Closed
AmirrezaFarnamTaheri wants to merge 3 commits into
Closed
AmirrezaFarnamTaheri wants to merge 3 commits into
AmirrezaFarnamTaheri wants to merge 3 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
9 tasks done
Author
|
Closing as a duplicate of #8438: superseded by broader motion and WebGL fix; the deterministic mascot-clock tests were transferred to the canonical PR. Keeping one upstream review thread avoids redundant CI and conflicting merges. The canonical PR remains draft pending review and CI. |
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The mascot RAF clock continuously runs when the page is hidden or the user requests reduced motion, wasting work and creating jumps when visibility changes.
Change
Introduce a shared
useAnimationActivityexternal-store hook for visibility and theprefers-reduced-motionmedia query. Accumulate active elapsed time inuseMascotClock, stopping RAF while hidden or reduced-motion and resuming without resetting or jumping.Tests
New deterministic hook tests stub
requestAnimationFrame,performance.now, page visibility, and media query changes, including pause/resume and cleanup.No model/provider or fork-only functionality. Draft pending upstream CI.