Skip to content

Update Rust CI images to hardened tinymold 0.3.2 - #36

Merged
senamakel merged 1 commit into
mainfrom
update-tinymold-security
Oct 20, 2026
Merged

senamakel merged 1 commit into
mainfrom
update-tinymold-security

Conversation

@senamakel

@senamakel senamakel commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Update both Rust CI image variants to tinymold 0.3.2, containing the untrusted-cache hardening from tinyhumansai/tinymold#54. Pin the Linux release archive's SHA-256 and require the installed version to match the Dockerfile pin in the image smoke test.

Validation: Bash syntax, source-asset tests (4 passed), mold-linker tests, and a direct check that the version guard rejects 0.3.1 and accepts 0.3.2. The Linux release artifact also passed health, CAS upload/download, and an oversized REAPI batch rejection on staging. Full image builds and smoke tests run in CI. Shellcheck reports the existing SC2034 warning for the unchanged MongoDB retry-loop variable.

Summary by CodeRabbit

  • Chores

    • Updated the Rust CI image’s TinyMold tooling to version 0.3.2.
    • Updated the accompanying setup documentation to reflect the current version.
  • Tests

    • Added a smoke check that verifies the installed TinyMold version matches the expected CI configuration.

Updates the tinymold version across the Dockerfile, README, and smoke script to 0.3.2 to use a newer release.

Auto-committed-on: macbook
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@tinysweeper

tinysweeper Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Incomplete
Priority: none
Reviewed head: e723c5a4a92b
Updated: 2026-10-20T17:54:06Z

Review snapshot

Change surface Files Review signal Count
Production 2 Active findings 0
Tests 0 Noted findings 0
Documentation 1 Resolved findings 0
Configuration 0 Pending checks/questions 7

Completeness: Incomplete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

  • Unreviewed: tinysweeper/tests

Findings

No active actionable findings.

Could not review: images/rust-ci/Dockerfile, images/rust-ci/README.md, images/rust-ci/smoke.sh, tinysweeper/description, tinysweeper/tests

Before merge

  • Complete the critique review for images/rust-ci/Dockerfile, images/rust-ci/README.md, images/rust-ci/smoke.sh.
  • Complete the security review for images/rust-ci/Dockerfile, images/rust-ci/smoke.sh.
  • Complete the tests review for tinysweeper/tests.
  • Complete the description review for tinysweeper/description.
Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: images/rust-ci/Dockerfile, images/rust-ci/README.md, images/rust-ci/smoke.sh
  • Lane summary: Reviewed 0 files; 0 findings. 3 files could not be reviewed: images/rust-ci/Dockerfile, images/rust-ci/README.md, images/rust-ci/smoke.sh.

security

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: images/rust-ci/Dockerfile, images/rust-ci/smoke.sh
  • Lane summary: Reviewed 0 files; 0 findings. 2 files could not be reviewed: images/rust-ci/Dockerfile, images/rust-ci/smoke.sh. 1 file was not security-reviewed: images/rust-ci/README.md (prose or tabular data).

tests

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: tinysweeper/tests
  • Lane summary: No reviewer produced a usable response.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: tinysweeper/description
  • Lane summary: No reviewer produced a usable response.
Evidence and run details
  • Models: ladder/vectors-oai3
  • Spend: $0.000020
  • Tokens: 0 input · 0 output · 0 cached · 153 embedding
Head State Pass summary
e723c5a4a92b incomplete 0 active finding(s), 0 resolved finding(s) (at 2026-10-20T17:54:06Z)

tinysweeper 0.1.2

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T17:55:49.879113Z e723c5a PR opened
🔒 Security Review ✅ Completed 2026-10-20T17:58:18.890971Z e723c5a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1f477907-7c40-4a98-be42-f3788ae71f72
📥 Commits

Reviewing files that changed from the base of the PR and between dd71bad and e723c5a.

📒 Files selected for processing: 3
  • images/rust-ci/Dockerfile
  • images/rust-ci/README.md
  • images/rust-ci/smoke.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Rust CI image now downloads TinyMold 0.3.2 and verifies it with the updated SHA-256 digest. The README documents version 0.3.2, and the smoke test checks the installed version against TINYMOLD_VERSION.

Changes: TinyMold version update

Layer / File(s) Summary
Pin and verify TinyMold version
images/rust-ci/Dockerfile, images/rust-ci/smoke.sh, images/rust-ci/README.md
The Dockerfile pins TinyMold 0.3.2 and its updated SHA-256 digest. The smoke test checks the reported version against TINYMOLD_VERSION. The README documents version 0.3.2.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to e723c

The TinyMold 0.3.2 update is consistently pinned, documented, and validated, with no identified merge-blocking risk.

Architecture risk: 🔵 Low · up to e723c

The change affects 1 system.

Changed systems: images

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — images (service) was modified; 3 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in images/rust-ci/Dockerfile: TinyMold is now downloaded as version 0.3.2 and verified against its new SHA-256 digest instead of version 0.3.1 and the previous digest.
  • observed — Modified behavior in images/rust-ci/README.md: The documented tinymold version was updated from 0.3.1 to 0.3.2.
  • observed — Modified behavior in images/rust-ci/smoke.sh: Added an exact version assertion for tinymold, comparing its reported version with the TINYMOLD_VERSION environment value.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating Rust CI images to the hardened tinymold 0.3.2 release.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the version pin,
Then sniffs the digest, fresh and bright.
The smoke test reads the version string,
The README marks the same delight.
I hop away; the build is right!

Comment @coderabbitai help to get the list of available commands.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking, but could not review everything, so this is not an approval: images/rust-ci/Dockerfile, images/rust-ci/README.md, images/rust-ci/smoke.sh, tinysweeper/description, tinysweeper/tests.

$0.0000 · 0 in / 0 out · 153 embedded · ladder/vectors-oai3

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 20, 2026
@senamakel
senamakel merged commit 49194ca into main Oct 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant