Repository navigation
feat(analyser): record each native's registry slot 🔢 - #231
Merged
Merged
Conversation
The resolver records each native symbol's position in the function registry, which is the global slot the VM gives it. The layout pass will turn these into global storage instead of relying on natives being declared first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2, step 1, stacked on #226. Later steps will stack on this branch.
The layout pass in phase 2 will turn native symbols into the VM's global slots, so it needs each native's position in the function registry. That position happened to equal the native's
SymbolId, because natives are declared first, but nothing guaranteed it. This makes the mapping explicit.NameResolverrecordsnative_slots, from each native symbol to its registry index. Overloads of the same name keep separate slots.expect(dead_code)outside tests, like the other fields waiting for later passes.No behaviour change.
🤖 Generated with Claude Code