Repository navigation
refactor(parser): parse None as a literal 🫥 - #229
Merged
Merged
Conversation
`None` was an identifier that the analyser and compiler each recognised by name, so it could never be shadowed and `let None = 5` was silently ignored. Lex it as a keyword and parse it as `Expression::NoneLiteral`, like `true` and `false`, removing both special cases. Binding `None` is now a parse error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nonewas parsed as an identifier, and the analyser and compiler each recognised it by name. So it could never be shadowed:let None = 5; print(None)printedNoneand silently ignored the binding. The new name resolver onfeat/new-analyserwould have needed a third copy of that special case. Running it over the functional tests showed 7 programs that useNonedisagreeing with the current pipeline, so this fixes the cause instead.Noneas a keyword, and the parser producesExpression::NoneLiteral, liketrueandfalse.name == "None"checks and handle the literal directly.Noneis a literal.Behaviour change: binding
Noneis now a parse error (let None = 5reports "Invalid assignment target"), where it used to be silently ignored. A new functional test covers it. The tree-sitter grammar still treatsNoneas an identifier, which only affects editor highlighting.🤖 Generated with Claude Code