Repository navigation
refactor(parser): give type annotation names node ids 🏷️ - #228
Merged
Merged
Conversation
Name resolution needs to record what each type name refers to. Each name in `Map<P, Q>` resolves separately, and annotations on parameters have no node of their own, so give every `TypeExpr::Name` its own `NodeId`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name resolver being built on
feat/new-analyserwill resolve type names through lexical scopes. Struct names are scoped like values, but they live in a separate type namespace. The resolver records its results in side tables keyed byNodeId, but type annotations had no node ids. Each name needs its own key: inMap<P, Q>,PandQresolve separately. Parameter annotations can't borrow an owner's id either, becauseFunctionParameterhas no node of its own. This follows the same approach as #225, which gave binding patterns and assignment targets their own ids.TypeExpr::Namegets anid: NodeId. Both places that build one assign a fresh id: ordinary annotations, and the cast fast path forx as Int < 5.TypeExpr::Tuplegets no id, because tuple types have no name to resolve. Nothing in the workspace compares annotations for equality, so including the id in the derivedPartialEqchanges no behaviour.🤖 Generated with Claude Code