Repository navigation
Conversation
Deleting a container now asks separately before removing named volumes (default off). Closing the window can minimize to a resident tray icon or quit after stopping running containers, with the choice saved in settings. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
GPUI's Window::window_handle shadows the raw-window-handle trait method, which broke the Windows MSI build. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
Match close-behavior buttons to language/theme row style. Always save the first close choice, and replace the cancel footer with a top-right dismiss icon. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
Map HRESULT 0x800700B7 to a localized message and re-sync orphan session VHDs into the catalog when create hits already-exists. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
Replace the primary-button toggle with a Checkbox so the named-volume delete choice is obvious in the remove-container dialog. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
Second desktop-icon click shows and activates the running window (minimized or tray-hidden) instead of an already-running dialog. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
Show version, repo/website links at the bottom of Settings. Compare CARGO_PKG_VERSION to GitHub releases/latest and open the release page when a newer version is available. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
Fill remaining EN/ZH UI strings (badges, about, inspect/exec, units, partial volume-delete). Reuse settings cards, status badges, scroll log panes, and default modal width. Bump package to 0.1.3; tag later after testing. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Named-volume delete confirm, tray close behavior, About update check via GitHub Releases, second-launch window focus, and shared UI/i18n polish. Co-authored-by: 绿岸公式 <chinesejar@gmail.com>
|
已 squash 合并到 Windows MSI 工作流正在为 tag 构建并创建 Release:https://github.com/timeroute/wslc-desktop/actions (GitHub Merge API 对此 token 返回 403,因此通过 push 到 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d970f585a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else { | ||
| item.name.clone() | ||
| }; | ||
| self.stop_container(&key)?; |
There was a problem hiding this comment.
Continue stopping remaining containers after a failure
When one running container fails to stop (for example, its stop times out), the ? returns immediately, so no later containers receive a stop request. The quit path then deliberately exits even on that error, leaving those later containers running without a UI despite the user selecting “Quit and stop running containers.” Attempt every running container and report any aggregated failures before exiting.
Useful? React with 👍 / 👎.
| }; | ||
| let key = Self::container_key(item); | ||
| let title = format!("{} · inspect", key); | ||
| let title = i18n::fmt1(self.t().container_inspect_heading, "name", &key); |
There was a problem hiding this comment.
Preserve the log modal type separately from its localized title
With the Chinese locale, this now stores a title such as {name} · 检查; however, render_logs_modal still determines whether the result is inspect or exec by searching for the English words inspect and exec. Consequently, both inspect and exec result dialogs are headed as ordinary container logs for Chinese users. Carry an operation kind alongside the result instead of inferring it from translated display text.
Useful? React with 👍 / 👎.
版本
本 PR 汇总为 0.1.3(
Cargo.toml已 bump)。请在本机测完后再打v0.1.3tag 触发 MSI Release。改动摘要
删除容器
关闭窗口 / 托盘
再次启动
设置 → 关于
releases/latest检查更新并跳转 Release 页。0.1.3 打磨
settings_card_section/status_badge/scroll_log_pane/ 默认模态宽度 480。验证
cargo test:20 项通过。