Block pull requests without a cross-SDK parity decision - #102
Open
brionmario wants to merge 1 commit into
Open
brionmario wants to merge 1 commit into
brionmario wants to merge 1 commit into
Conversation
A capability that ships here usually has to ship in the other ThunderID SDKs too, and until now nothing at review time asked whether it did. The SDK development specification states that the decision is made on every pull request; this wires that up. Every pull request must carry exactly one of parity/prs-raised or parity/prs-not-needed. The check stays red until it does, and a label is the only thing that clears it, so a change is never waved through on the strength of the files it happened to touch. Applying the label re-runs the check, so it goes green without a push. The logic lives in thunder-id/.github and is shared by all four SDK repositories, which cannot drift as a result. This file owns only the triggers, which a reusable workflow cannot declare for its caller. Signed-off-by: Brion <info@brionmario.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A capability that ships here usually has to ship in the other ThunderID SDKs too, and until now nothing at review time asked whether it did. The SDK development specification states that the parity decision is made on every pull request; this wires that up, as the second half of the proposal in thunder-id/thunderid#5354.
Approach
Every pull request must carry exactly one of
parity/prs-raisedorparity/prs-not-needed. The check stays red until it does, and a label is the only thing that clears it, so a change is never waved through on the strength of the files it happened to touch. Applying the label re-runs the check, so it goes green without a push.Alongside the gate, the check keeps a single comment listing the sibling SDK repositories and ticks the boxes itself as port links appear in the pull request body or in replies on the thread, so nobody maintains that list by hand.
The logic lives in thunder-id/.github and is shared by all four SDK repositories, which cannot drift as a result. This file owns only the triggers, which a reusable workflow cannot declare for its caller, and passes nothing: the sibling list is derived from the repository the check runs in.
The pull request template gains the matching line.
Testing
The shared workflow was exercised against a stubbed
github-scriptenvironment and then dry run end to end on a throwaway pull request, which confirmed it blocks the pull request red with the checklist comment, goes green the moment the label is applied without a push, and updates its comment in place rather than posting again. Details in thunder-id/.github#3.Related Issues
Related PRs
uses:reference here does not resolve.Notes for merging
🔀 Cross-SDK Parity / 🏷️ Parity Decision. Renaming either job later breaks the protection rule.Checklist
breaking changelabel added.parity/prs-raisedorparity/prs-not-neededadded.parity/prs-raised, the port links are posted as a reply on the parity check's comment.Security checks