Make nightly workflow consistent with other SDK repos - #101
Merged
Merged
Conversation
Signed-off-by: Brion <info@brionmario.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 14, 2026
DonOmalVindula
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The nightly workflow here is named
🌙 E2E Nightly (latest ThunderID)in a file callede2e-nightly.yml, while the three mobile SDK repositories use🌙 Nightly E2Einnightly.yml. The same scheduled suite therefore appears under two different names depending on which repository you are looking at.Approach
Adopt the mobile naming, since three repositories already use it and one does not. The file becomes
nightly.yml, its name becomes🌙 Nightly E2E, and the job id becomese2enamed🎭 E2E Tests, matching the mobile repositories exactly. A stale reference to the old filename in.github/actions/run-e2e-suite/action.ymlis updated with it.Renaming the file means GitHub retires the old scheduled workflow and registers the new one. The schedule, the trigger and the suite itself are unchanged, and the nightly is not a required check, so nothing depends on the old job name.
The Google Chat notification this repository already has is untouched. The mobile pull requests linked below add the equivalent, which is the other half of making these four consistent.
Related Issues
Related PRs
SDK parity
The same change is raised in every SDK repository, so the four nightlies behave and are named the same way:
Checklist
breaking changelabel added.Security checks