Skip to content

Make nightly workflow consistent with other SDK repos - #101

Merged
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:nightly-chat-notification
Sep 15, 2026
Merged

brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:nightly-chat-notification

Conversation

@brionmario

@brionmario brionmario commented Sep 14, 2026

Copy link
Copy Markdown
Member

Purpose

The nightly workflow here is named 🌙 E2E Nightly (latest ThunderID) in a file called e2e-nightly.yml, while the three mobile SDK repositories use 🌙 Nightly E2E in nightly.yml. The same scheduled suite therefore appears under two different names depending on which repository you are looking at.

Approach

Adopt the mobile naming, since three repositories already use it and one does not. The file becomes nightly.yml, its name becomes 🌙 Nightly E2E, and the job id becomes e2e named 🎭 E2E Tests, matching the mobile repositories exactly. A stale reference to the old filename in .github/actions/run-e2e-suite/action.yml is updated with it.

Renaming the file means GitHub retires the old scheduled workflow and registers the new one. The schedule, the trigger and the suite itself are unchanged, and the nightly is not a required check, so nothing depends on the old job name.

The Google Chat notification this repository already has is untouched. The mobile pull requests linked below add the equivalent, which is the other half of making these four consistent.

Related Issues

  • N/A

Related PRs

SDK parity

The same change is raised in every SDK repository, so the four nightlies behave and are named the same way:

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
    • The renamed workflow parses as valid YAML and its job resolves.
    • No references to the old filename remain in the repository.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards.
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

Signed-off-by: Brion <info@brionmario.com>
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 9467a934-029f-4a68-8a1f-d645f6c50bf7


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brionmario brionmario changed the title Align the nightly workflow name with the mobile SDK repositories Make nightly workflow consistent with other SDK repos Sep 14, 2026
@brionmario
brionmario merged commit 08788fc into thunder-id:main Sep 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants