[ja573]

MET-WP11-B-CLIPPY-01 — restore unsuppressed Clippy with diesel_derives 2.3.10

DRAFT. Implementation submitted for independent review. MERGE HOLD. This PR is not independently approved; the implementing agent does not approve, ready, or merge it.

Field	Value
Owning issue	#985 (HIGH)
Parent programme-integration task	#981 (CRITICAL)
Outer integration PR	#984 (feature/metrics -> develop), untouched by this PR
Approved specification	#981 original + Amendments 1-6 (CTO 6126801903), Amendments 7A 6273625367 / 7B 6288115189 / 7C 6288991064, exact #985 body (SHA-256 e27f048a5ed25d5b5fdeeb3e2823cc38b3ceddb5329e21ee6c4bf082034edd1f)
Independent specification review	#981 6296015048 — APPROVED, specification only
CTO specification approval	#981 6296026365 — APPROVED, specification only
Authorized base M (feature/metrics)	d5451f8516fa18126f6f4969fb3409775408e242, tree c15d07c3d48bb84fab6033307369c51de2258506
Included D (develop), unchanged	b44303c214498baf76c9d9a0a7cab374377f9cbe, tree 050e1e2954b518d62988e31d74a7d9c280b8822c
Child head (single commit on M)	1014fb7ea244181d0a3112cb38e3bdd8a3d9bd3c (tree 4e8100ffda8c9427b90dfb30cf56f248ead35ccc)
Task branch	feature/metrics--wp11-b-clippy

Change

Cargo.lock — exactly two lines in the diesel_derives stanza; diesel stays 2.3.10:

-version = "2.3.9"
+version = "2.3.10"
-checksum = "d1817b7f4279b947fc4cafddec12b0e5f8727141706561ce3ac94a60bddd1cf5"
+checksum = "ecbd51fb6c020672543641167efa4e6417ff7ad76849ed556ace3595e72de03a"

The 2.3.10 checksum equals the crates.io sparse-index cksum and the SHA-256 of the registry .crate. Upstream, QueryableByName now emits shorthand named-field initializers (Self { id, name } instead of Self { id: id, name: name }) — the generated code behind all 346 unique / 347 rendered clippy::redundant_field_names positions in 36 files at M (run 38806270979, lint job 116667915795). A diagnostic cargo update --precise also flipped prost-build's heck 0.5.0 -> 0.4.1; that collateral was discarded and the two lines were edited directly.

Documentation, within the approved budget:

• the existing Thoth-specific post-A2 programme-flow sentence in docs/engineering/ai-delivery/branching-and-release-workflow.md, docs/engineering/repository-map/branch-topology.md, docs/metrics/README.md and docs/metrics/task-status.md: keeps the prohibition on normal post-A2 slices, separates the develop-refresh recovery from this single one-time CI correction under thoth-pub/thoth#981 / thoth-pub/thoth#985, requires renewed exact-list A2 after this slice merges and before B, and preserves B's CRITICAL review and merge authorization;
• one CHANGELOG.md [Unreleased] / ### Fixed entry citing MET-WP11-B-CLIPPY-01 - Restore unsuppressed Clippy before final Metrics integration #985;
• new docs/engineering/ai-delivery/implementation-reports/MET-WP11-B-CLIPPY-01-implementation-report.md.

Diff against M: 6 modified files + 1 new report; zero .rs files; no Cargo.toml, migration, schema.rs, GraphQL, workflow, classifier, lint configuration or suppression change. All 36 #985 inventory paths are blob-identical to M.

Local validation (reference toolchain rustc/cargo 1.99.0, clippy 0.1.99; disposable PostgreSQL 17.10 UTF8 + Redis 8.10)

• git diff --check, cargo fmt --all -- --check, cargo metadata --locked, cargo check --workspace --locked: exit 0; Cargo.lock unchanged by every --locked step.
• cargo test --workspace --locked: exit 0 — 2339 passed, 0 failed, 11 ignored (3 existing #[ignore] unit tests, 8 ignored doctests), against disposable PostgreSQL 17.10 UTF8 and Redis 8.10.
• cargo clippy --all --all-targets --all-features --locked -- -D warnings: exit 0, zero lint diagnostics (only Cargo's out-of-scope proc-macro-error2 future-incompat advisory, also present at M). Same-toolchain control with M's Cargo.lock: exit 101 with exactly the 346 CI positions.
• Resolved graph M vs candidate: 564/564 packages; only diesel_derives 2.3.9 -> 2.3.10 (identical features and deps) and diesel's edge to it; prost-build keeps heck 0.5.0.
• Workspace-generated SDL (thoth-client/assets/schema.graphql, untracked): exact M and candidate both 2681b54ac18296f886451d08f5396c0a9ef8351762f63f7b3f80f319ae505496, byte-identical, equal to the pinned hash.
• All 36 MET-WP11-B-CLIPPY-01 - Restore unsuppressed Clippy before final Metrics integration #985 inventory paths: Git blob identical to M (listed in the report).

Expected automatic effects of this draft PR

Classifier for this path set: run_build=true, run_migrations=false, run_docker=true. Opening or synchronizing this PR runs build/test/lint/format and check-changelog, skips the migration job, and pushes the staging image ghcr.io/thoth-pub/thoth:staging-pr-<this PR> (not a release, migration or deployment). No workflow is manually dispatched or rerun. Natural CI and the observed image digest are collected for the implementation handoff.

Effects

No migration, data, SQL, schema.rs, GraphQL/API, authentication/authorization, concurrency, runtime, configuration, feature-flag or deployment change.

Remaining gates (each separately authorized)

1. Independent cross-model HIGH exact-head source review of this PR.
2. Draft-to-ready transition of this PR.
3. Exact-SHA CTO TRUE MERGE COMMIT authorization into feature/metrics (parents [M, this head]; no squash/rebase), including the automatic MET-WP11-THOTH-API-01-B: final Metrics programme integration into develop #984 synchronization, its CI and staging-pr-984 replacement.
4. Renewed exact-list A2 bound to the post-merge feature/metrics head M2 (this branch included); the original 37 retired refs stay absent.
5. MET-WP11-THOTH-API-01-B: final Metrics programme integration into develop #984 rebinding to M2, fresh cumulative CRITICAL B review and new exact-head merge authorization. MET-WP11-THOTH-API-01-B: final Metrics programme integration into develop #984 stays DRAFT / MERGE HOLD meanwhile.
6. Release, migration, deployment and activation gates remain separate.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-20T17:52:43.162563Z	1014fb7	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.