Repository navigation
Conversation
…known-issues Commit 0b0592c ("topology: Add sof-hda-generic-idisp-uaol") added sof-hda-generic-idisp-uaol.tplg concurrently with commit bdd3d7c ("tools: topology: validator: add validation rules and command line tool"), which only listed sof-hda-generic-uaol for rule W004 (UAOL DAI type not yet in the upstream kernel find_dai() table). Broaden the pattern to sof-hda-generic*uaol so sof-hda-generic-idisp-uaol.tplg also matches the W004 waiver in top-level_default_CMake_target_ALL. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues with the W004 waiver-pattern expansion for the iDisp UAOL topology.
No open issues 🎉
What changed in this PR
Extends the topology validator’s W004 known-issue waiver to cover sof-hda-generic-idisp-uaol.tplg, whose UAOL DAI type is not yet recognized by the upstream kernel.
Changes:
- Broadens
sof-hda-generic-uaoltosof-hda-generic*uaol, covering both the existing and iDisp UAOL topologies.
| File | Description |
|---|---|
tools/topology/validator/known-issues.txt |
Expands the W004 waiver pattern to include the iDisp UAOL topology. |
Review effort: Balanced
PR 11418: test resultsRun date: 2026-11-07 14:40 UTC Tested commit: a16462ba361c28f7c88efa8747eaa4b5bb3356eb
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 0b0592c ("topology: Add sof-hda-generic-idisp-uaol") added
sof-hda-generic-idisp-uaol.tplgconcurrently with commit bdd3d7c ("tools: topology: validator: add validation rules and command line tool"), which only listedsof-hda-generic-uaolfor ruleW004(UAOLDAI type not yet in the upstream kernelfind_dai()table).Broaden the pattern to
sof-hda-generic*uaolsosof-hda-generic-idisp-uaol.tplgalso matches theW004waiver intop-level_default_CMake_target_ALL.