Repository navigation
Conversation
dcpleung
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
November 6, 2026 22:16
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The missing CONFIG_ prefix leaves RIMAGE_MANIFEST undefined on cAVS builds, causing module-driver lookup to return NULL for every module and preventing IPC4 component creation.
1 open issue
What changed in this PR
This PR aims to migrate IPC4’s cAVS platform check to Zephyr’s replacement Kconfig symbol while preserving manifest-based component lookup.
Changes:
- Updates the cAVS preprocessor condition used to enable
RIMAGE_MANIFEST.
| File | Description |
|---|---|
src/ipc/ipc4/helper.c |
Updates the cAVS symbol in the manifest-support condition. |
Review effort: Balanced
|
|
||
| /* TODO: Remove platform-specific code, see https://github.com/thesofproject/sof/issues/7549 */ | ||
| #if defined(CONFIG_SOC_SERIES_INTEL_ADSP_ACE) || defined(CONFIG_INTEL_ADSP_CAVS) | ||
| #if defined(CONFIG_SOC_SERIES_INTEL_ADSP_ACE) || defined(SOC_SERIES_INTEL_ADSP_CAVS) |
...CONFIG_INTEL_ADSP_CAVS. Upstream Zephyr is deprecating the old kconfig so changing it to use the new one. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
dcpleung
force-pushed
the
kconfig/cavs
branch
from
November 6, 2026 22:26
ac6c2e2 to
2d7b707
Compare
PR 11416: test resultsRun date: 2026-11-06 23:14 UTC Tested commit: 2d7b7073b5146ddbf84ad6284681c3da62cf47ab
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...CONFIG_INTEL_ADSP_CAVS. Upstream Zephyr is deprecating the old kconfig so changing it to use the new one.