Enable two-center case in test_poisson_bvp_gives_the_correct_laplacian - #331
Phantom8420 wants to merge 1 commit into
Conversation
this was commented out as failing. it passes now with default params (verified locally, atol=1e-2, both on-grid and random points).
PaulWAyers
left a comment
There was a problem hiding this comment.
It looks like a good contribution to me. I'd want @marco-2023 and/or @Ao-chuba to confirm that this test now no longer needs to be commented out, however, as I'm not especially familiar with this part of the code.
|
Gentle bump. CI is green on all platforms here, including the case that was commented out. Happy to add anything that would help confirm it's safe to enable. |
|
@Specter842 |
This case was commented out with
# TODO: Couldn't get the following test to pass.I ran it against current master (two Gaussians at (0,0,0) and (1,1,1), default params) and it passes: max abs error ~6e-3 on grid points and ~3e-14 on random points, both under the existing atol=1e-2. Looks like it was fixed as a side effect of other work since this was written, just never re-checked. Uncommenting it.