chore(docs): rewrite the protocol internals pages [skip-line-limit] - #2038
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedNext included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: theinterfold/interfold/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hmzakhalid
added this pull request to stack #2040
September 26, 2026 13:42
9 tasks
ctrlc03
previously approved these changes
Sep 26, 2026
ctrlc03
force-pushed
the
docs/internals
branch
from
September 26, 2026 15:35
691e96b to
ab8a6af
Compare
ctrlc03
force-pushed
the
docs/internals
branch
from
September 26, 2026 15:57
ab8a6af to
11fa65d
Compare
Rewrite the sortition, PVDKG and ZK proof, and commitment consistency pages for auditors and core contributors. - Sortition documents the per-bond-owner committee cap (#1994). - The DKG page covers the H-member roster, crash tolerance, the public-input layouts of both final proofs, and the presets. - Commitment consistency lists all 12 links and the accusation flow. - Corrections include: no WaitingForRoster state; the C1 proof travels in KeyshareCreated; the secure preset lambda is 50; the accusation quorum is H; plaintext aggregation starts at T + 1 roster shares.
hmzakhalid
force-pushed
the
docs/internals
branch
from
September 26, 2026 19:04
11fa65d to
2af1c78
Compare
hmzakhalid
removed this pull request from stack #2040
September 26, 2026 19:13
hmzakhalid
added this pull request to stack #2042
September 26, 2026 19:15
An error occurred while trying to automatically change base from
docs/crisp
to
main
September 26, 2026 21:15
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 11 of 12 of the docs rewrite. This stack replaces #2010, which was too large to review. Each layer builds on the one below it. Merge the layers in order.
Changes
Rewrite the sortition, PVDKG and ZK proof, and commitment consistency
pages for auditors and core contributors.
public-input layouts of both final proofs, and the presets.
in KeyshareCreated; the secure preset lambda is 50; the accusation
quorum is H; plaintext aggregation starts at T + 1 roster shares.
Review focus
Sortition, the DKG and proof pipeline, and commitment consistency. This is the most technical layer.
Verification
The facts on these pages were checked against the code at release 0.18.0. Where noted, they were also checked against mainnet or Sepolia state on 25 September 2026.
At this layer:
pnpm buildindocs/passes,pnpm check:addressespasses, and Prettier passes on the changed files.Each changed page passes a per-page check: Nextra compile, internal links, and the ASD-STE100 punctuation rules. The archival whitepaper and the constitution are kept word for word.