Require Node 20, matching @testingbot/automation-mcp - #3
Merged
Merged
Conversation
engines.node said >=18 and preflight() enforced 18, but the bundled @testingbot/automation-mcp hard-fails its own preflight below Node 20. A Node 18 user installed cleanly and then died at startup with an error pointing at the dependency rather than at their runtime. Raised in all four places that claimed 18: engines.node, preflight(), and the two README mentions. The existing version test now expects the 20 message, and a new case pins 18.20.0 specifically — the version that used to pass here and fail one layer down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2. That PR bumped the dependency to
@testingbot/automation-mcp@0.1.8; this closes the runtime-floor mismatch it exposes.The problem
engines.nodedeclared>=18andpreflight()enforced 18 — but the bundled@testingbot/automation-mcphard-fails its own preflight below Node 20. A Node 18 user installed cleanly, started the server, and died with an error pointing at the dependency rather than at their own runtime.0.1.8 didn't introduce this.
@testingbot/automation-mcphas declared>=20inengines.nodeall along; its runtime check was the thing that lagged at 18, and 0.1.8 corrected it. So the mismatch here was always latent and is now reachable.Changes
Raised in all four places that claimed 18:
package.json—engines.nodesrc/server-factory.ts—preflight(), with a comment tying it to bothengines.nodeand the dependency's floorREADME.md— the Prerequisites line and the troubleshooting stepThe existing version test now expects the 20 message, and a new case pins 18.20.0 specifically: the version that used to pass here and fail one layer down.
Note on who this affects
This narrows who can install the package, which is why it's a separate PR rather than folded into the release bump. In practice the affected population is people on Node 18 who were already broken at startup — they now get an accurate error at the right layer, and npm warns them at install time instead.
CI already runs Node 22 only, so no workflow changes are needed.
Verification
npm run buildpasses: version sync, lint, format, 254 tests (up one), tsc.