Package the Windows runtime with 7-Zip, and build runtimes in PR CI - #58
Merged
Merged
Conversation
The v5.0 release built no Windows distribution: dist/archive.sh calls zip, which Git Bash on the windows-latest runners does not have, so the job failed with "zip: command not found" before verifying anything. Fall back to 7z, which the runners do have. That leg had never passed, and nothing before a tag could show it, because only release.yml builds the runtimes -- and a tag also publishes to Maven Central. CI now builds and verifies the Linux and Windows runtimes on every pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v5.0 release shipped no Windows distribution.
dist/archive.shcallszip, which Git Bash on thewindows-latestrunners does not have:Changes
dist/archive.shfalls back to7z(preinstalled on the Windows runners) whenzipis absent.test.ymlgains aruntimejob that builds and verifies the jlink runtime on Linux and Windows for every PR. Until now onlyrelease.ymlbuilt them, on a tag, by which point Maven Central has already published -- which is how a Windows leg that had never passed reached a release.macOS is left out of the PR job because what it adds over Linux is signing, which needs secrets a pull request does not get.
Verification
This PR's own
runtime (windows-latest)job is the test: it is the first time the Windows leg runs past the archive step.Windows then ships in 5.0.1.