Fix repeated Deep Agents tool calls with identical arguments - #1806
Open
1fanwang wants to merge 1 commit into
Open
Fix repeated Deep Agents tool calls with identical arguments#18061fanwang wants to merge 1 commit into
1fanwang wants to merge 1 commit into
Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
When a Deep Agent requested the same tool and arguments twice in one workflow,
only the first call ran. The second call returned the first result without
scheduling its Temporal Activity.
run_deep_agentcaches activity results for continue-as-new. The tool cache keynow includes the call ID as well as the tool name and arguments. Separate calls
run independently, while replay of the same call can still reuse its result.
Why?
Before this fix, a side-effecting tool requested twice with identical arguments
ran only once. After the fix, workflow history records two
deepagents.invoke_toolActivity schedules.Checklist
No issue. This is a small, self-contained bug fix.
The regression test drives a real Deep Agents workflow against a local Temporal
server and makes two tool calls with the same arguments but different call IDs.
Red on main
Green with this fix
The changelog includes the corrected behavior. The public API is unchanged.