Prevent workflow stream subscriptions from hiding cancellation - #1805
Open
1fanwang wants to merge 2 commits into
Open
Prevent workflow stream subscriptions from hiding cancellation#18051fanwang wants to merge 2 commits into
1fanwang wants to merge 2 commits into
Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an activity blocks in
WorkflowStreamClient.subscribeand its workflowcancels it, the subscription currently ends like a normal iterator. The activity
can then return success even though Temporal requested cancellation. This change
propagates the cancellation to the activity.
The subscription now rethrows direct task cancellation and cancellation wrapped
by
WorkflowUpdateRPCTimeoutOrCancelledError. RPC timeouts and server-side RPCcancellation keep their existing continue-as-new and terminal-workflow handling.
Testing
The regression test starts a real Temporal dev server, waits until a heartbeating
activity is polling a workflow stream, and then cancels that activity. The
activity catches
CancelledErrordirectly around the subscription and returns adistinct sentinel, so an error added later by the activity runtime cannot satisfy
the assertion.
Before
After