ci: select explicit release tag - #1204
Draft
chaptersix wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Follow-up to the v1.9.0 release asset build.
What changed?
GoReleaser chooses the first version-sorted tag pointing at
HEAD. When bothv1.9.0-rc.1andv1.9.0point at the same commit, it selects the RC tag even when the workflow was triggered by publishing the final release.This change passes the GitHub release tag directly to GoReleaser. Manual workflow runs now require the intended tag, check out that tag, and pass it to GoReleaser as well. This allows the
v1.9.0assets to be rebuilt without deleting or moving the RC tag.Validation
git diff --checkv1.9.0andv1.9.0-rc.1point at commit2ecba7d58c1a2a648791e34af0b80e5331f3dab3--sort=-version:refnameordering, which placesv1.9.0-rc.1beforev1.9.0Follow-up
After merge, manually dispatch the Release workflow with
tagset tov1.9.0.