Skip to content

fix: preserve IME composition in dashboard - #43

Open
lux-liang wants to merge 1 commit into
techjarves:mainfrom
lux-liang:fix/dashboard-ime-composition-27
Open

lux-liang wants to merge 1 commit into
techjarves:mainfrom
lux-liang:fix/dashboard-ime-composition-27

Conversation

@lux-liang

Copy link
Copy Markdown

Summary

  • track compositionstart and compositionend on the Dashboard prompt
  • require both the browser event and the explicit composition state to be inactive before Enter submits
  • serve the small Composer keyboard helper through the Dashboard's explicit static-file map

This keeps Enter-to-send unchanged for normal input while preventing Firefox IME confirmation from being treated as message submission.

Closes #27.

Tests

  • node tools/check.mjs
  • node --test tests/*.test.mjs (52 passed)
  • added focused coverage for active composition, Shift+Enter, browser isComposing, and normal Enter
  • added an HTTP assertion that /composer.js is served successfully

rainman74 pushed a commit to rainman74/ClaudeCode-Portable that referenced this pull request Nov 13, 2026
rainman74 added a commit to rainman74/ClaudeCode-Portable that referenced this pull request Nov 14, 2026
The changelog compared against rainman74/ClaudeCode-Portable at 247aeb1,
which is this fork, not the project it came from. Measured against the real
upstream (techjarves/ClaudeCode-Portable at b3660fd) the fork has nine commits
of its own, including two community pull requests and the update-check work.

- State the actual baseline and note the one later upstream commit (dfdc58d,
  a sponsor button) that this fork does not include.
- Add an "Adopted community pull requests" section crediting PR techjarves#43 (lux-liang,
  IME-safe composer) and PR techjarves#47 (VikasRajput-18, HTTP for private LAN hosts).
  Both are still open upstream; the included code matches the PR branches.
- Document the runtime update check with pin rollback, custom model-window and
  model-picker mapping, and the dashboard conversation delete button.
- Correct the test baseline from 54 to 50 tests, measured at the merge base.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@rainman74

Copy link
Copy Markdown

Thanks for this fix. It is included in our fork, rainman74/ClaudeCode-Portable.

It was merged together with #47 in commit d1a6bf4. dashboard/composer.js with isComposerSubmitKey(), its use in the composer's key handler, and tests/composer.test.mjs are all present there.

Credit to lux-liang is recorded in the fork's CHANGELOG.md, which documents the delta to this repository. Until this is merged upstream, users who need IME-safe Enter handling can use the fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Japanese IME input broken in Web Dashboard (Linux/Chrome+Firefox)

2 participants