fix(proof): count only admitted provider observations - #101
Merged
Merged
Conversation
tangletools
approved these changes
Sep 27, 2026
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 189d3583
Blanket team auto-approval is intentional. The merge gates are CI and codex-p1.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-09-27T04:22:42Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduced bug
The merged provider-observation loop counted a poll before admitting the deadline.
An already-expired shared deadline produced observerCalls0 and attempts0, but reported polls1.
The single regression fails on main571b25fd with
1 !== null.Fix
Move the counter immediately before
observe(), after deadline admission.The expired path now retains observerCalls0/attempts0 and pollsnull (unobserved).
An admitted observer still produces observerCalls1/polls1.
Exactly one regression covers this reproduced metric bug.
Scope is only
provider-observation.mjsand the existing narrow test file.Frozen cases, prompts, model, sleep180, cleanup and the default-OFF optimization flag are unchanged.
No app, README, docs, CI or release changes.
Verification
pnpm run check: PASS, exit0.This fixes metric truth; it claims no speed gain.
The real protected baseline remains827s full wall/821s runner slot, n=1.
Root owns review, merge and the next signed/protected dispatch.