Plan-dumper: Add a timing-jitter diff filter - #162
Merged
Conversation
Regenerating touches every file's timing fields (Postgres' "Actual Total
Time", DuckDB's "cpu_time", Hyper's "cpu-cycles", ...), which is
expected but adds noise on top of the real diff. `filter-timing-diff.py`
strips hunks where every changed line differs only in one of those fields:
git diff | plan-dumper/filter-timing-diff.py
A line that changes for any other reason is kept as-is, timing/cycle-count
included — it only special-cases lines that changed for no other reason.
`--revert` goes further and `git checkout --`s every file whose diff is
purely timing jitter, so after regenerating the plans, `git diff` shows
only real changes.
vogelsgesang
force-pushed
the
plan-dumper-duckdb-umbra
branch
from
August 24, 2026 17:19
5ed2240 to
a5c63ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerating touches every file's timing fields (Postgres' "Actual Total Time", DuckDB's "cpu_time", Hyper's "cpu-cycles", ...), which is expected but adds noise on top of the real diff.
filter-timing-diff.pyundoes all timing-only changes, so after regenerating the plans,git diffshows only real changes.:A line that changes for any other reason is kept as-is, timing/cycle-count included. It only undoes lines that changed for no other reason.