[symfony] Relax RequireRouteNameToGenerateControllerRouteRule for Symfony 6.4+ FQCN routes - #332
Closed
TomasVotruba wants to merge 1 commit into
Closed
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…pt any #[Route] on __invoke() Since Symfony 6.4 the FQCN route alias is auto-created for any route name, so requiring #[Route(name: self::class)] produced false positives. Only fire when the __invoke() controller has no #[Route] at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326
Since Symfony 6.4, the FQCN route alias is auto-created for any invokable controller that has a
#[Route], regardless of itsname- see https://symfony.com/blog/new-in-symfony-6-4-fqcn-based-routesSo requiring
#[Route(name: self::class)]above__invoke()produced false positives:$router->generate(SomeController::class)resolves fine as long as the controller has any route.This relaxes the rule to only fire when the
__invoke()controller has no#[Route]at all (or has no__invoke()), which is the case wheregenerate()genuinely cannot resolve.