Skip Symfony-only rules that would misfire on Laravel projects - #331
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Most Symfony rules already self-scope: they gate on Symfony base classes, interfaces, attributes or
Symfony\/Doctrine\type prefixes, so on a non-Symfony project (e.g. Laravel) they never fire.Four rules did not self-gate and could misfire on plain PHP / Laravel classes:
NoConstructorAndRequiredTogetherRule- only checks__construct()+@requireddoc tagNoListenerWithoutContractRule- triggers on any class named*ListenerNoNullableServiceInConstructorRule- triggers on any nullable constructor dependencyNoServiceJugglingRule- triggers onautowire*method namingWhat
Adds
LaravelPresenceResolver, which detects a Laravel project viaReflectionProvider->hasClass('Illuminate\Foundation\Application')(ReflectionProvider overclass_exists, per the repo's own rule). The four rules early-return when Laravel is present.Behavior on non-Laravel projects is unchanged - plain PHP libraries keep these rules. Only a project with Laravel installed skips them.
Tests
LaravelPresenceResolverTest