Add configurable PreferInlineTraitRule to spot lazy traits - #330
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in PHPStan rule that spots traits used only a few times across the project - good candidates to inline into their single user, empowering IDE, Rector and PHPStan.
Uses two collectors to count trait definitions and
use SomeTrait;usages across files, then reports traits used at mostmaxUsagetimes (default 2).Disabled by default. Enable via:
This replaces the standalone
spot-lazy-traitscommand in rector/swiss-knife with a native PHPStan rule that runs in the existing analysis pass and resolves real trait FQNs.Note: pre-existing PHPStan error in
CommandMustHaveAsCommandAttributeRule.php:71is unrelated to this PR and already present on main.