Skip to content

[symfony] Cover variable and new 2nd arg in SingleArgEventDispatchRule - #323

Merged
TomasVotruba merged 4 commits into
mainfrom
skip-variable-new-second-arg-event-dispatch
Sep 25, 2026
Merged

TomasVotruba merged 4 commits into
mainfrom
skip-variable-new-second-arg-event-dispatch

Conversation

@TomasVotruba

@TomasVotruba TomasVotruba commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Add fixtures for dispatch() with 2 args:

  • 2nd arg is a variable holding a constant string, e.g. $eventName = 'some_event' - reported
  • 2nd arg is an untyped method argument - skipped
  • 2nd arg is a new expression - skipped

The existing type-based check already handles all of them, these fixtures lock the behavior in.

@TomasVotruba TomasVotruba changed the title [symfony] Skip variable and new 2nd arg in SingleArgEventDispatchRule [symfony] Cover variable and new 2nd arg in SingleArgEventDispatchRule Sep 25, 2026
@TomasVotruba
TomasVotruba marked this pull request as ready for review September 25, 2026 10:14
@TomasVotruba
TomasVotruba merged commit 63838e7 into main Sep 25, 2026
8 checks passed
@TomasVotruba
TomasVotruba deleted the skip-variable-new-second-arg-event-dispatch branch September 25, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant