Repository navigation
Let AI predictions fill empty prediction slots - #1038
Merged
Merged
Conversation
Generated words now follow the instant words in the next free slot instead of always starting at slot four, and words that can't be shown for the typed prefix no longer leave gaps. Closes #1037 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The neural benchmark assumed generated words always sit in slots four to six. Add an engine test for generated words filling instant slots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1037
What changed
model.rs: when the AI refinement arrives, its words follow the normal predictions and take the next free slot, so[help, _, _, helpful, helping, helped]becomes[help, helpful, helping, helped, _, _]. There are still at most three AI words.worker.rs: each shown word takes the next free slot, so a word dropped because it doesn't match the typed prefix no longer leaves a gap. Labels and inserts share the same index, so accepting a slot still inserts the word shown there.Validation
neural_integration_benchmarkstill assumed AI words were in slots 3-5. That is fixed, and an end-to-end engine test (generated_words_fill_slots_the_instant_words_left) is added. A second independent review on7f51619reported no actionable findings.generated_words_take_the_next_free_slot(model merge) andunshown_words_leave_no_gap(worker labels and acceptance);refinement_preserves_the_displayed_acceptance_and_retires_it_on_ackupdated for the compacted slot.npm run lint,npm test(295 passed),npm run build,cargo fmt --check,cargo clippy --all-targets -D warnings,cargo test(761 passed, 5 ignored): all pass locally on Windows.npm run prediction-modelfailed locally with anEPERMrename in.cache/prediction-neural, a Windows file lock unrelated to this change. CI runs it on clean runners.🤖 Generated with Claude Code