Repository navigation
fix: validate format capture length types - #332
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format capture lengths could accept DWARF pointers lowered to LLVM integers, and named lengths could convert script string pointers into byte counts. Validate source types before lowering
.*and.name$lengths, resolve aliases, and report the placeholder plus the offending argument or variable.Keep no-length hex/ASCII conversions compatible with captured scalar and aggregate bytes. Add compiler and real-DWARF regression coverage and document the length requirement in English and Chinese.
Validation:
cargo fmt --alland formatting check passed.cargo clippy --all-targets --all-features -- -D warnings -D clippy::undocumented_unsafe_blockspassed; compiler Clippy also passed after the final pointer-arithmetic check.cargo test -p ghostscope-compiler --lib: 194 passed.a64c4585341c), including the new non-integer-length regression and existing format tests.