Repository navigation
Fix author update authorization and recovery token validation - #417
Merged
Merged
Conversation
Run the author update handler only after mandatory authentication and administrator checks, preventing anonymous and regular users from changing indexed author metadata. Reject unknown password recovery UUIDs before accessing the recovery expiry field, avoiding a nil-pointer panic on public reset-password requests. Add regression tests for anonymous, regular, and administrator access to author updates, and for reset-password requests with unknown recovery tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Here are a couple of fixes 👀
Run the author update handler only after mandatory authentication and administrator checks, preventing anonymous and regular users from changing indexed author metadata
Reject unknown password recovery UUIDs before accessing the recovery expiry field, avoiding a nil-pointer panic on public reset-password requests
Add regression tests for anonymous, regular, and administrator access to author updates, and for reset-password requests with unknown recovery tokens