Repository navigation
Fix focus, approval and copy issues found in the v0.2.0 pre-release review - #157
Merged
Merged
Conversation
- Hand focus to the Touch ID prompt before it can activate itself, and return it only if the user did not switch to another app meanwhile. - Count overlapping prompts and reconcile the Dock state afterwards. - Present the next approval when a retried one has expired. - Keep approval privacy and idle-lock timers running in common modes. - Ignore repeated Unlock clicks while Touch ID is showing.
- Replacing a credential on import keeps its permission; the picker says so. - Approval Details mark the requesting Agent's name as self-declared. - Access records describe denied and failed requests as requests. - The welcome page's try-it step matches the saved permission. - Agent access no longer promises a lookup before every use. - The sample prompt skips expired credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #127. Follow-up issues: #158.
Why
The v0.2.0 acceptance on the maintainer's Mac found focus problems one at a time. Before the next attempt, an independent read-only review (Codex
gpt-6.1-sol) of all focus/Touch ID paths and of every user-visible v0.2 change was run; the planner verified each finding against the code. Release-relevant findings are fixed here; the rest are filed in #158.Focus and Touch ID
Approvals
Copy and import
Checks
swift build: passed.swift test --filter AskKeyAppTests: 345 passed, 0 failed (includes a new welcome-step test; updated assertions for the new copy).swift test --filter 'ManagementAuthentication|ManagementDock|AgentApproval|SessionPolicy|VaultViewModel|Unlock': 51 passed, 0 failed.python3 scripts/check_hygiene.py,python3 scripts/check_module_deps.py,git diff --check: passed.