[ugc-proxy] Add support for basic auth API credentials via secrets - #305
Merged
Conversation
DanielRaapDev
previously approved these changes
Aug 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the sophora-ugc-proxy Helm chart to support sourcing UGC Proxy API basic-auth credentials from a Kubernetes Secret, and bumps the chart metadata accordingly.
Changes:
- Adds
authentication.apiBasicAuthconfiguration tovalues.yamlfor enabling basic auth and referencing secret keys. - Injects
AUTH_USERNAME/AUTH_PASSWORDenvironment variables into the Deployment from the configured secret keys. - Bumps chart version and updates
artifacthub.io/changesannotation to reflect the new feature.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/sophora-ugc-proxy/values.yaml | Adds new authentication.apiBasicAuth values for secret-based API credentials. |
| charts/sophora-ugc-proxy/templates/deployment.yaml | Conditionally wires secret-backed env vars for API basic auth into the pod spec. |
| charts/sophora-ugc-proxy/Chart.yaml | Bumps chart version and updates Artifact Hub changelog annotation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Jonas Pruditsch <6641029+kunstkomputer@users.noreply.github.com>
Co-authored-by: Daniel Raap <raap@subshell.com>
DanielRaapDev
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.