Repository navigation
fix(outreach): our own comments are not replies - #37
Merged
Merged
Conversation
…as a reply The status check treated any comment as a response, so a follow-up note (or an update we posted) flipped the issue to 'discussed' and suppressed the one check-in it was meant to allow.
✅ Deploy Preview for explainmyrepo canceled.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by running
outreach statusagainst the live REA issue: our own update comment made it read as 'discussed / 100% responded', which would have suppressed the follow-up. Comments authored by the sender are now ignored. Test added.