Repository navigation
⬆️ kettle-jem: update the Duel template for Duel 0.1.1 - #83
Merged
Merged
Conversation
The Perf workflow now comments on a pull request only when Duel says to (by default when it fails), and posts a new comment instead of editing the last one. Duel 0.1.1 watches the benchmarks, .duel.rb and the version files itself, so .duel.rb only adds the workflow, and the modular Gemfile requires 0.1.1 or later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duel 0.1.1 is out, and it changes how the workflow comments, so this brings the template from #81 up to date.
The Comment job now runs only when Duel says to (by default only when a benchmark fails, and
c.commentin.duel.rbcan change that), and it always posts a new comment instead of editing the last one, so the pull request keeps every report. Each comment's marker records the run's status, so after a failure the first passing run posts once to say it's fixed. Duel passes the decision and status to the workflow as step outputs, so the Comment job still runs none of the branch's code. I kept the template's own pins,[ci skip]guard, concurrency and version-file lookup as they were..duel.rbnow only adds the workflow toc.watch, since 0.1.1 watches the benchmarks,.duel.rband the version files itself, and it mentionsc.commentwith its default.duel.gemfilerequires 0.1.1 or later, since older versions don't write the outputs the workflow reads.The Duel spec covers the new outputs, the Comment job's condition and script (with no
PATCHanywhere), the watch line and the floor. The rest of the suite fails the same 4 specs here as onmain.