Add per-source retry interval to MultiplexedSource - #68
Merged
Merged
Conversation
Lets a rescuer or fallback source that is usually down be redialed less often than every 5s.
billettc
requested changes
Sep 18, 2026
Comment on lines
-83
to
+100
| time.Sleep(sourceReconnectDelay) | ||
| time.Sleep(s.reconnectDelay) |
Contributor
There was a problem hiding this comment.
This sleep is still hidden. To loop calling the Run() should be the one sleeping. Expose reconnectDelay and use it on the loop...
billettc
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
MultiplexedSourceWithRetryIntervals([]time.Duration)option, indexed like the source factories. A source with an interval is not redialed until that much time has passed since its last connection attempt. Sources without one keep the current behavior (redialed on every 5s pass).This is for a rescuer or fallback endpoint that is down most of the time and would otherwise be dialed, and fail, every 5s. Used by the relayer's
retry_intervalsource parameter in streamingfast/firehose-core#260.The reconnect loop delay is now copied into a field at construction so tests can set it per instance instead of writing the package variable.