Repository navigation
fix: preserve transaction type and delta filters with ynab 4.5.0 - #53
Open
stephendolan wants to merge 1 commit into
Open
stephendolan wants to merge 1 commit into
stephendolan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With ynab 4.5.0, transaction-list type filters occupy the SDK's added
untilDateargument, causinguntil_date=unapproved,type=42, and omission of delta knowledge. This breaks CLI and MCP callers of the shared plan/account/category/payee methods.Use the SDK's typed named request interfaces for all four methods and retain normal response decoding with
.value(). Set the dependency floor to 4.5.0 and lock that version so local and CI checks exercise the affected SDK.Verified through the real SDK with only global fetch mocked and synthetic IDs/token: all four request-contract cases failed before the fix and pass afterward, asserting
type=unapproved,last_knowledge_of_server=42, and nountil_date.npx tsc --noEmit, all 49 tests (bun run test --run), lint, and build pass. Auth tests use temporary config storage; CI and release checks run the declared Vitest script because Bun's native runner lacks its mock APIs/isolation. The existing Biome schema incompatibility prevents formatting checks.Integration lessons are documented in
docs/sdk-integration.md.Fixes #52.