Repository navigation
Report unparseable single-header responses as MalformedResponse - #696
Merged
Merged
Conversation
jadamcrain
added a commit
that referenced
this pull request
Oct 22, 2026
jadamcrain
enabled auto-merge
October 22, 2026 23:06
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 22, 2026
jadamcrain
added a commit
that referenced
this pull request
Oct 22, 2026
jadamcrain
force-pushed
the
fix/single-header-malformed
branch
from
October 22, 2026 23:15
c83a1a4 to
bb62248
Compare
jadamcrain
enabled auto-merge
October 22, 2026 23:15
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 22, 2026
Restart, delay measure and file read read their response through get_only_object_header, whose error conversions turned a parse failure into UnexpectedResponseHeaders and dropped the ObjectParseError. Commands and the other file tasks already report MalformedResponse with the cause, so carry the cause in SingleHeaderError::BadParse and map it the same way. UnexpectedResponseHeaders remains for well-formed responses with no header, more than one, or the wrong one.
jadamcrain
enabled auto-merge
October 22, 2026 23:20
jadamcrain
force-pushed
the
fix/single-header-malformed
branch
from
October 22, 2026 23:20
bb62248 to
b12deea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restart, delay-measure (time sync) and file read tasks now report a response whose objects cannot be parsed as MalformedResponse with its cause, like commands and the other file tasks. UnexpectedResponseHeaders stays for well-formed responses with the wrong headers.