Skip to content

fix: exclude ./src/tests - #2

Closed
blackravenx wants to merge 1 commit into
stencil-community:mainfrom
blackravenx:fix/exclude-example-components-type-declaration
Closed

blackravenx wants to merge 1 commit into
stencil-community:mainfrom
blackravenx:fix/exclude-example-components-type-declaration

Conversation

@blackravenx

Copy link
Copy Markdown

Closes #1

@blackravenx

Copy link
Copy Markdown
Author

needs review @TheCelavi @johnjenkins

TheCelavi
TheCelavi previously approved these changes Oct 7, 2026
@TheCelavi

Copy link
Copy Markdown
Collaborator

Thanks!

@johnjenkins

Copy link
Copy Markdown
Contributor

@blackravenx tests fail now obviously. You'll need 2 tsconfig files - one for test and one for prod build? (then 2 corresponding stencil.config.*.ts loading the different tsconfigs).

I'm not 100% sure why you're seeing the error re React / Components honestly - the final package excludes the test components from the Components namespace (via https://github.com/stencil-community/context/blob/main/stencil.config.ts#L19)

🤔

image

@TheCelavi

Copy link
Copy Markdown
Collaborator

Oh, my bad 🤦‍♂️

Will take a look at this in detail.

@TheCelavi
TheCelavi dismissed their stale review October 7, 2026 16:29

Incorrect, found an issue, Stencil compiler do discover components in src/test directory. Can be excluded with typescript, but that does not prevents stencil to discover components inside.

Seams that tests are the issue, I will need to rework them.

@TheCelavi

Copy link
Copy Markdown
Collaborator

Closing in favour of: #3

@TheCelavi TheCelavi closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude Example components from type declaration

3 participants