[devodii]

What

A transaction that Blockaid simulated as a revert, for example an insufficient balance, was labeled "This transaction was flagged as suspicious". The details sheet title stayed "Proceed with caution" and the only detail was the revert string, so a transaction that will fail read like a safety warning.

Fix

The security check now reads the verdict first. Malicious and Warning are unchanged. A simulation error with no Warning or Malicious verdict is labeled "This transaction is likely to fail". The details sheet title is "Likely to fail", and Confirm anyway is not treated as destructive when the only finding is a revert. Send and swap review uses the same label.

Tested

• Unit tests cover the security level, banner copy, and sign screen.
• yarn build:extension passes.
• A stubbed sign request with a simulation error and a Benign verdict shows the new banner and details sheet.

[netlify]

👷 Deploy request for freighter-docs pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	1e9de9d

[Copilot]

🟡 Changes recommended

The malicious-site banner can open details that show only “Likely to fail,” omitting the site risk because the site severity and warning reason are not forwarded.

1 open issue

• Malicious site warning missing from transaction details · New

What changed in this PR

This PR distinguishes transaction simulation failures from security risks in Freighter’s signing, send, and swap review flows.

Changes:

• Adds a “likely to fail” classification while preserving higher-priority malicious and suspicious verdicts.
• Updates banners, details-sheet copy, and confirmation styling for simulation-only failures.
• Adds English and Portuguese strings and updates regression tests.

File	Description
extension/​src/​popup/​views/​SignTransaction/​index.tsx	Stops treating simulation errors alone as destructive confirmations.
extension/​src/​popup/​views/​__tests__/​SignTransaction.test.tsx	Expects the new failure banner text.
extension/​src/​popup/​locales/​pt/​translation.json	Adds Portuguese failure messages.
extension/​src/​popup/​locales/​en/​translation.json	Adds English failure messages.
extension/​src/​popup/​helpers/​blockaid.ts	Separates simulation failures from suspicious verdicts.
extension/​src/​popup/​helpers/​__tests__/​blockaid.test.tsx	Tests failure classification and verdict precedence.
extension/​src/​popup/​constants/​blockaid.ts	Adds and ranks LIKELY_TO_FAIL.
extension/​src/​popup/​constants/​__tests__/​blockaid.test.ts	Tests the new severity ordering.
extension/​src/​popup/​components/​WarningMessages/​index.tsx	Adds failure-specific details-sheet titles and subtitles.
extension/​src/​popup/​components/​InternalTransaction/​ReviewTransaction/​index.tsx	Integrates failure warnings into send and swap review.
extension/​src/​popup/​components/​BlockaidBanner/​index.tsx	Adds the shared “likely to fail” banner label.
extension/​src/​popup/​components/​BlockaidBanner/​__tests__/​BlockaidBanner.test.tsx	Tests the failure banner label.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are recorded for the changes distinguishing simulation failures from security risks.

No open issues 🎉

1 resolved since last review

• Malicious site warning missing from transaction details

_{Review effort: Balanced}